This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
Warnings on setting propTypes, defaultProps and contextTypes of MobxStoreInjector
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warnings won't be issued in production.
|
@jtraub specific reason to close this one? |
|
@mweststrate I saw you rewrote the code so the PR had merge conflicts. I thought it would be easier to manually reimplement if you still need this |
| @@ -302,6 +302,25 @@ | |||
| }); | |||
| Injector.contextTypes = { mobxStores: PropTypes.object }; | |||
| Injector.wrappedComponent = component; | |||
|
|
|||
| if (process.env.NODE_ENV !== 'production') { | |||
There was a problem hiding this comment.
Can throw error if process is not defined
|
yep, seems useful, I'll open issue just to not forget :) |
|
@jtraub merged it nonetheless :) thanks for the contribution! |
mweststrate
added a commit
that referenced
this pull request
Aug 6, 2016
mweststrate
referenced
this pull request
Nov 10, 2016
This change forward writes (but not reads!) of `propTypes` and `defaultProps` on an inject based HoC to the wrapped component, so that propTypes and defaultProps can be defined in a straight forward way.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code throws warnings when user tries to attach
propTypes,defaultPropsandcontextTypestoMobxStoreInjectorinstead of wrapped component. See #70 and #84.